Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag loading #34096

Merged
merged 4 commits into from
Sep 16, 2022
Merged

Tag loading #34096

merged 4 commits into from
Sep 16, 2022

Commits on Sep 15, 2022

  1. Add minimumInputLength for tags select 

    Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
    @kesselb
    kesselb committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    e1d9b0b View commit details
    Browse the repository at this point in the history

  2. Improve loading for tags 

    When opening the tag select and type something the tags are loaded.

If you continue to type but the tags are not finally loaded yet (the first xhr request is still running)
another xhr request is triggered. This happens for every keystroke.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
    @kesselb
    kesselb committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    1bfac6d View commit details
    Browse the repository at this point in the history

  3. Rewrite OC.SystemTags.getDescriptiveTag to vanilla js 

    For every tag a deprecation warning is emitted.
With 10k tags the ui becomes unresponsive and inspector crashed occasionally.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
    @kesselb
    kesselb committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    700875d View commit details
    Browse the repository at this point in the history

  4. Compile core-systemtags.js and systemtags-systemtags.js 

    Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
    @kesselb
    kesselb committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    3a59180 View commit details
    Browse the repository at this point in the history