Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename database password toggle #3403

Merged
merged 1 commit into from
Feb 8, 2017
Merged

Conversation

MorrisJobke
Copy link
Member

How to test

  • go to setup page
  • choose a DB with a password
  • enter everything
  • click the "show password" button on the DB password
  • click the install button
  • before: install fails (because password is set to on) after: install completes

cc @GitHubUser4234

* otherwise submitting the form with the password show will be overwritten
* see https://github.com/nextcloud/server/blob/2c9d7eeb763d2f907eea8234f6c60a829a5d39f7/core/Controller/SetupController.php#L59
* seems to be a legacy fallback
* fixes #3381

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @nickvergessen and @butonic to be potential reviewers.

@codecov-io
Copy link

Codecov Report

Merging #3403 into master will increase coverage by <.01%.

@@             Coverage Diff              @@
##             master    #3403      +/-   ##
============================================
+ Coverage     53.99%   53.99%   +<.01%     
  Complexity    21007    21007              
============================================
  Files          1303     1303              
  Lines         80373    80373              
  Branches       1253     1253              
============================================
+ Hits          43395    43396       +1     
+ Misses        36978    36977       -1
Impacted Files Coverage Δ Complexity Δ
core/templates/installation.php 0% <ø> (ø) 0 <ø> (ø)
lib/private/Security/CertificateManager.php 93.81% <ø> (+1.03%) 38% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4bbb3...f1c4f4c. Read the comment docs.

@GitHubUser4234
Copy link
Contributor

Thanks a lot @MorrisJobke

@skjnldsv
Copy link
Member

skjnldsv commented Feb 8, 2017

Wow, that is an unfortunate issue! ^^
Good catch!

@nickvergessen nickvergessen merged commit f5c42fe into master Feb 8, 2017
@nickvergessen nickvergessen deleted the rename-dbpassword-toggle branch February 8, 2017 11:16
@felixdivo
Copy link

Thank you for fixing this so quick!

I currently have this problem and have read that it will be fixed in milestone 12. Can you roughly estimate when I can use nextcloud with that new fix? Thanks. :)

@MorrisJobke
Copy link
Member Author

Thank you for fixing this so quick!

I currently have this problem and have read that it will be fixed in milestone 12. Can you roughly estimate when I can use nextcloud with that new fix? Thanks. :)

Hard to say, but I would say, that we release this in roughly 1-2 months. But don't nail me on this fact ;)

@MorrisJobke
Copy link
Member Author

@karlitschek Is the backport of this okay?

@MorrisJobke
Copy link
Member Author

stable11: #3500

@karlitschek
Copy link
Member

please backport 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to install Nextcloud with MySQL and unmasked DB password
8 participants