-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename database password toggle #3403
Conversation
* otherwise submitting the form with the password show will be overwritten * see https://github.com/nextcloud/server/blob/2c9d7eeb763d2f907eea8234f6c60a829a5d39f7/core/Controller/SetupController.php#L59 * seems to be a legacy fallback * fixes #3381 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @nickvergessen and @butonic to be potential reviewers. |
Codecov Report@@ Coverage Diff @@
## master #3403 +/- ##
============================================
+ Coverage 53.99% 53.99% +<.01%
Complexity 21007 21007
============================================
Files 1303 1303
Lines 80373 80373
Branches 1253 1253
============================================
+ Hits 43395 43396 +1
+ Misses 36978 36977 -1
Continue to review full report at Codecov.
|
Thanks a lot @MorrisJobke |
Wow, that is an unfortunate issue! ^^ |
Thank you for fixing this so quick! I currently have this problem and have read that it will be fixed in milestone 12. Can you roughly estimate when I can use nextcloud with that new fix? Thanks. :) |
Hard to say, but I would say, that we release this in roughly 1-2 months. But don't nail me on this fact ;) |
@karlitschek Is the backport of this okay? |
stable11: #3500 |
please backport 👍 |
server/core/Controller/SetupController.php
Line 59 in 2c9d7ee
dbpassword
todbpassword-toggle
How to test
on
) after: install completescc @GitHubUser4234