Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Wait for the new user form to be visible in acceptance tests #33792

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/acceptance/features/bootstrap/UsersSettingsContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,12 @@ public function iSeeThatTheListOfUsersDoesNotContainsTheUser($user) {
* @Then I see that the new user form is shown
*/
public function iSeeThatTheNewUserFormIsShown() {
Assert::assertTrue(
$this->actor->find(self::newUserForm(), 10)->isVisible());
if (!WaitFor::elementToBeEventuallyShown(
$this->actor,
self::newUserForm(),
$timeout = 10 * $this->actor->getFindTimeoutMultiplier())) {
Assert::fail("The new user form is not shown yet after $timeout seconds");
}
}

/**
Expand Down