Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Add to your Nextcloud #33227

Closed
wants to merge 1 commit into from
Closed

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 13, 2022

Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: federation labels Jul 13, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Jul 13, 2022
@szaimen szaimen requested review from jancborchardt, juliusknorr, a team, PVince81, skjnldsv and Pytal and removed request for a team July 13, 2022 15:16
@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

/backport to stable24

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

/backport to stable22

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a change on purpose to be brandable through #25950 but from my perspective the product name of the "HanssonIT VM" should still be "Nextcloud".

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

This was a change on purpose to be brandable through #25950

cc @jancborchardt

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not okay 👎🏼

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

Closing as discussed internally

@szaimen szaimen closed this Jul 13, 2022
@szaimen szaimen deleted the enh/noid/add-to-your-nextcloud branch July 13, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: federation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants