Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port encryption admin settings to vue #32506

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

CarlSchwan
Copy link
Member

This also remove the button to run a migration since that button was pointing to an URL without a controller and was for ownloud < 8, so probably got removed sometimes ago in the backend but not in the frontend

When enabling

image

When enabled
image

@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone May 19, 2022
@CarlSchwan CarlSchwan requested a review from a team May 19, 2022 22:22
@CarlSchwan CarlSchwan self-assigned this May 19, 2022
@CarlSchwan CarlSchwan requested review from PVince81, Pytal and vanpertsch and removed request for a team May 19, 2022 22:22
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 20, 2022
@CarlSchwan CarlSchwan requested a review from skjnldsv May 20, 2022 13:29
@CarlSchwan
Copy link
Member Author

ping?

apps/settings/src/components/Encryption.vue Outdated Show resolved Hide resolved
apps/settings/src/components/Encryption.vue Show resolved Hide resolved
apps/settings/src/components/Encryption.vue Outdated Show resolved Hide resolved
$this->initialState->provideInitialState('mandatory2FAState', $this->mandatoryTwoFactor->getState());
$this->initialState->provideInitialState('two-factor-admin-doc', $this->urlGenerator->linkToDocs('admin-2fa'));
$this->initialState->provideInitialState('encryption-enabled', $this->manager->isEnabled());
$this->initialState->provideInitialState('encryption-ready', $this->manager->isReady());

Check notice

Code scanning / Psalm

UndefinedInterfaceMethod

Method OCP\Encryption\IManager::isReady does not exist
@CarlSchwan CarlSchwan requested review from artonge and removed request for vanpertsch June 21, 2022 16:29
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan merged commit d7bd6f0 into master Jul 13, 2022
@CarlSchwan CarlSchwan deleted the port/vue-encryption branch July 13, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants