-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port encryption admin settings to vue #32506
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
added
3. to review
Waiting for reviews
technical debt
feature: accessibility
labels
May 19, 2022
CarlSchwan
requested review from
PVince81,
Pytal and
vanpertsch
and removed request for
a team
May 19, 2022 22:22
CarlSchwan
commented
May 19, 2022
Pytal
reviewed
May 20, 2022
skjnldsv
reviewed
May 20, 2022
skjnldsv
reviewed
May 20, 2022
skjnldsv
reviewed
May 20, 2022
skjnldsv
reviewed
May 20, 2022
skjnldsv
reviewed
May 20, 2022
skjnldsv
reviewed
May 20, 2022
skjnldsv
reviewed
May 20, 2022
skjnldsv
requested changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
skjnldsv
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
May 20, 2022
CarlSchwan
force-pushed
the
port/vue-encryption
branch
from
May 20, 2022 13:10
342cd69
to
7545dc2
Compare
CarlSchwan
commented
May 20, 2022
CarlSchwan
force-pushed
the
port/vue-encryption
branch
from
May 20, 2022 15:47
7545dc2
to
d81d59f
Compare
ping? |
Pytal
reviewed
May 27, 2022
artonge
requested changes
May 30, 2022
CarlSchwan
force-pushed
the
port/vue-encryption
branch
from
May 31, 2022 08:24
d81d59f
to
1a10026
Compare
CarlSchwan
force-pushed
the
port/vue-encryption
branch
from
June 15, 2022 13:46
1a10026
to
0ce3556
Compare
$this->initialState->provideInitialState('mandatory2FAState', $this->mandatoryTwoFactor->getState()); | ||
$this->initialState->provideInitialState('two-factor-admin-doc', $this->urlGenerator->linkToDocs('admin-2fa')); | ||
$this->initialState->provideInitialState('encryption-enabled', $this->manager->isEnabled()); | ||
$this->initialState->provideInitialState('encryption-ready', $this->manager->isReady()); |
Check notice
Code scanning / Psalm
UndefinedInterfaceMethod
Method OCP\Encryption\IManager::isReady does not exist
artonge
approved these changes
Jun 23, 2022
Pytal
approved these changes
Jun 27, 2022
nextcloud-command
force-pushed
the
port/vue-encryption
branch
from
June 28, 2022 08:42
0ce3556
to
370c4ca
Compare
CarlSchwan
force-pushed
the
port/vue-encryption
branch
from
July 13, 2022 12:08
370c4ca
to
20bc5d6
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
port/vue-encryption
branch
from
July 13, 2022 12:59
20bc5d6
to
4e0574e
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also remove the button to run a migration since that button was pointing to an URL without a controller and was for ownloud < 8, so probably got removed sometimes ago in the backend but not in the frontend
When enabling
When enabled