Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add share attributes + prevent download permission #32482

Merged
merged 13 commits into from
Aug 1, 2022
Merged

Add share attributes + prevent download permission #32482

merged 13 commits into from
Aug 1, 2022

Commits on Jul 28, 2022

  1. Add share attributes + prevent download permission 

    Makes it possible to store download permission

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81 @CarlSchwan
    PVince81 authored and CarlSchwan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    a95c19e View commit details
    Browse the repository at this point in the history

  2. Fix share controller to accept share attributes alone 

    Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81 @CarlSchwan
    PVince81 authored and CarlSchwan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    9493f86 View commit details
    Browse the repository at this point in the history

  3. Fix share attribute related tests + code style 

    Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81 @CarlSchwan
    PVince81 authored and CarlSchwan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    03b1791 View commit details
    Browse the repository at this point in the history

  4. Attempt to fix sqlite json issue 

    Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81 @CarlSchwan
    PVince81 authored and CarlSchwan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    dbbc426 View commit details
    Browse the repository at this point in the history

  5. Don't reset share attributes when not specified 

    When not specified in the OCS call, don't reset the share attributes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81 @CarlSchwan
    PVince81 authored and CarlSchwan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    54a0d8f View commit details
    Browse the repository at this point in the history

  6. Add nc:share-attributes Webdav property 

    Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81 @CarlSchwan
    PVince81 authored and CarlSchwan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    92e60e3 View commit details
    Browse the repository at this point in the history

  7. Add share attrs + download permission support in frontend 

    Added download permission checkbox in frontend
Added share attributes parsing and setting in frontend.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81 @CarlSchwan
    PVince81 authored and CarlSchwan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    a11c6e7 View commit details
    Browse the repository at this point in the history

  8. Fix adding to empty attributes and duplicate request 

    Signed-off-by: Julius Härtl <jus@bitgrid.net>
    @juliusknorr @CarlSchwan
    juliusknorr authored and CarlSchwan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    2fb7a1f View commit details
    Browse the repository at this point in the history

  9. Fix view-only code after code review comments 

    Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81 @CarlSchwan
    PVince81 authored and CarlSchwan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    2ee659e View commit details
    Browse the repository at this point in the history

  10. Block download when needed on direct download endpoint 

    Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81 @CarlSchwan
    PVince81 authored and CarlSchwan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    3cfb4cb View commit details
    Browse the repository at this point in the history

  11. Inherit hide download from share attributes 

    When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81 @CarlSchwan
    PVince81 authored and CarlSchwan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    bbb5043 View commit details
    Browse the repository at this point in the history

  12. Enforcing permission during resharing 

    Signed-off-by: Carl Schwan <carl@carlschwan.eu>
    @CarlSchwan
    CarlSchwan committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    ab1a205 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2022

  1. Multiple fixes 

    - Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
    @CarlSchwan
    CarlSchwan committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    7b72381 View commit details
    Browse the repository at this point in the history