Add a method to get estimated export size in IMigrator #32206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
come-nc
requested review from
Pytal,
tcitworld,
a team,
ArtificialOwl,
skjnldsv and
vanpertsch
and removed request for
a team
|
master is 25 :) |
tcitworld
reviewed
Apr 28, 2022
|
/backport to stable24 |
4 tasks
Pytal
force-pushed
the
enh/migrator-add-estimatedsize-getter
branch
from
76d176f
to
2f59a05
Compare
|
Using a sample calendar that would be representative a regular user's calendar and querying select avg(size) from oc_calendarobjects where calendarid = <id>resulted in select avg(size) from oc_cards where addressbookid = <id>resulted in Base64 encoded contact image sizes can't be quickly estimated currently given that uploaded images are not re-encoded on upload to target a size range nor any other way available which would not require reading the image data itself, so estimation of those are not taken into account and out of scope for now |
Pytal
added
enhancement
3. to review
tcitworld
reviewed
Apr 29, 2022
(This is because 24 is now out we cannot modify IMigrator) |
come-nc
force-pushed
the
enh/migrator-add-estimatedsize-getter
branch
from
b08ad17
to
9d8b4dd
Compare
|
@Pytal Ready for review |
Pytal
force-pushed
the
enh/migrator-add-estimatedsize-getter
branch
from
9d8b4dd
to
dc832d1
Compare
|
Commits overwritten by force push have been restored |
Pytal
approved these changes
May 25, 2022
|
/rebase |
CarlSchwan
approved these changes
May 30, 2022
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…ator Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
nextcloud-command
force-pushed
the
enh/migrator-add-estimatedsize-getter
branch
from
dc832d1
to
faa3a94
Compare
Pytal
added
4. to release
…edSize Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/migrator-add-estimatedsize-getter
branch
from
faa3a94
to
d009e4d
Compare
|
Updated autoloaders |
Pytal
force-pushed
the
enh/migrator-add-estimatedsize-getter
branch
from
d009e4d
to
ff70912
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/migrator-add-estimatedsize-getter
branch
from
ff70912
to
aaedc95
Compare
|
CI failure unrelated |
Pytal
added
the
pending documentation
Pytal
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com