Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating events with old (< unix time) lastoccurence #31790

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Apr 1, 2022

Makes sure the timestamp is > 0 in the bigint column.

Closes #20804

  • Check if there's no edge effects introduced by this
  • Add unit test

@tcitworld tcitworld added bug 2. developing Work in progress php Pull requests that update Php code feature: caldav Related to CalDAV internals labels Apr 1, 2022
@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@tcitworld
Copy link
Member Author

/rebase

@tcitworld tcitworld self-assigned this Jun 22, 2023
@nextcloud-command nextcloud-command force-pushed the fix-events-with-old-lastoccurence branch from 2768d55 to f736485 Compare June 22, 2023 16:26
@tcitworld tcitworld force-pushed the fix-events-with-old-lastoccurence branch 2 times, most recently from 82a949a to 3f72635 Compare June 23, 2023 07:12
@tcitworld tcitworld added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 23, 2023
@tcitworld tcitworld force-pushed the fix-events-with-old-lastoccurence branch from 3f72635 to 9c5c82d Compare June 23, 2023 07:14
@tcitworld
Copy link
Member Author

Backports ?

@miaulalala
Copy link
Contributor

/backport to stable27

@miaulalala
Copy link
Contributor

/backport to stable26

@miaulalala
Copy link
Contributor

/rebase

@miaulalala
Copy link
Contributor

/backport to stable25

Closes #20804

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@nextcloud-command nextcloud-command force-pushed the fix-events-with-old-lastoccurence branch from 9c5c82d to 1e390e1 Compare June 27, 2023 11:16
@ChristophWurst ChristophWurst merged commit f43c24b into master Jun 29, 2023
@ChristophWurst ChristophWurst deleted the fix-events-with-old-lastoccurence branch June 29, 2023 07:42
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug feature: caldav Related to CalDAV internals php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webcal cache: fails with bad DTEND date
4 participants