highlight active navigation entry better, fix #2096

[jancborchardt]

Before & after:

Fix #2096, please review @MariusBluem @BernhardPosselt @nextcloud/designers

What’s left to do here is properly hook it up to $nextcloud-blue, but the apps.css is not in the assets folder yet. @skjnldsv or is that already possible?
Also it should use the theme color – @juliushaertl how to best do that?

[MorrisJobke]

I also fixed that the themed color is used:

[MorrisJobke]

Also it should use the theme color – @juliushaertl how to best do that?

Done 😝

[MorrisJobke]

Works and looks fantastic

[codecov-io]

Current coverage is 53.92% (diff: 100%)

Merging #3150 into master will increase coverage by 0.01%

@@             master      #3150   diff @@
==========================================
  Files          1302       1302          
  Lines         80148      80165    +17   
  Methods        7909       7915     +6   
  Messages          0          0          
  Branches       1248       1248          
==========================================
+ Hits          43211      43230    +19   
+ Misses        36937      36935     -2   
  Partials          0          0          

Diff Coverage	File Path
•••••••••• 100%	apps/theming/lib/Controller/ThemingController.php

Powered by Codecov. Last update 61d4198...3798f84

[skjnldsv]

Nice idea!! :D

[BernhardPosselt]

\o/

[jancborchardt]

@BernhardPosselt thanks for continuing to nag about this! :) It's really a lot more usable now

@MorrisJobke thanks for fixing the theming part!

[Dennis1993]

I have installed the latest master and the left border works perfectly.

But I think the 2px is a little bit to small. Maybe we can use 4px to display the border for better view?
Whats your opinion?

Or maybe a light background in grey? I prefer the 4px instead the 2px to Show the current link :)

[BernhardPosselt]

This ^

[jancborchardt]

It’s already a dark text and dark icon and that color on the side. If it’s too wide, it takes too much attention as it’s too present and one of the few colored things on the page. Remember it’s only an indicator, not a call to action.

[BernhardPosselt]

Maybe use a light circular box shadow to expand the blue a bit?

[BernhardPosselt]

Needs mockups but my php install segfaults all the time, @Dennis1993 can you play around a bit more?

[MariusBluem]

Can we have this for the personal-settings too 🤔 One-pager could make this more difficult 😁 @jancborchardt

[MorrisJobke]

A time traveler 😱

[MorrisJobke]

Can we have this for the personal-settings too 🤔 One-pager could make this more difficult 😁 @jancborchardt

See #3346