Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix settings error message timeout #31358

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Fix settings error message timeout #31358

merged 1 commit into from
Mar 4, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 25, 2022

See title 👆

@Pytal Pytal added this to the Nextcloud 24 milestone Feb 25, 2022
@Pytal Pytal requested a review from a team February 25, 2022 20:06
@Pytal Pytal self-assigned this Feb 25, 2022
@Pytal Pytal requested review from PVince81, artonge and skjnldsv and removed request for a team February 25, 2022 20:07
@Pytal
Copy link
Member Author

Pytal commented Feb 25, 2022

/compile amend /

@Pytal
Copy link
Member Author

Pytal commented Feb 25, 2022

/backport to stable23

@Pytal
Copy link
Member Author

Pytal commented Feb 25, 2022

/backport to stable22

@Pytal Pytal changed the title Fix error message timeout Fix settings error message timeout Feb 25, 2022
PVince81
PVince81 approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pytal Pytal force-pushed the fix/error-message-timeout branch from 4c57ac8 to b793349 Compare March 2, 2022 00:01
@Pytal

This comment was marked as outdated.

Sign in to view
@Pytal Pytal requested a review from artonge March 2, 2022 00:03
@PVince81

This comment was marked as outdated.

Sign in to view
@Pytal Pytal force-pushed the fix/error-message-timeout branch from 9b9a3f5 to bbb2944 Compare March 4, 2022 04:46
@Pytal
Copy link
Member Author

Pytal commented Mar 4, 2022

/compile amend /

@Pytal @nextcloud-command
Fix settings error message timeout
c22cfa0 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal Pytal removed the 3. to review Waiting for reviews label Mar 4, 2022
@Pytal Pytal added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 4, 2022
@Pytal Pytal merged commit f1604cf into master Mar 4, 2022
@Pytal Pytal deleted the fix/error-message-timeout branch March 4, 2022 06:10
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 4, 2022 •
edited by Pytal
Loading

The backport to stable23 failed. Please do this backport manually.

#31457

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 4, 2022 •
edited by Pytal
Loading

The backport to stable22 failed. Please do this backport manually.

#31458

This was referenced Mar 4, 2022
Merged
Merged
@Pytal Pytal mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: settings
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @PVince81 @artonge @skjnldsv