Use consistent url for the preview with the activity app #31346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
feat/consistent-url
branch
from
6eb7e50
to
71c1274
Compare
Merged
Merged
Allows to incrase the likehook of browser cache hits Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
feat/consistent-url
branch
from
71c1274
to
6e58f61
Compare
Otherwise the order of the parameters given to the router is not consitent with the one that the API user gives. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
feat/consistent-url
branch
from
6e58f61
to
5d82106
Compare
artonge
reviewed
Apr 20, 2022
There was a problem hiding this comment.
URLSearchParams might be useful here, and I think it will keep the entry order as for a Map
Using the sort method might make it even more robust to ensure the order is always the same
|
@CarlSchwan see comment above |
Merged
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
|
Outdated with new Files app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to increase the likelihood of browser cache hits
Needs nextcloud/activity#744
Signed-off-by: Carl Schwan carl@carlschwan.eu