Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/31237/new button auth token setup dialogue #31340

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Fix/31237/new button auth token setup dialogue #31340

merged 1 commit into from
Mar 1, 2022

Conversation

vanpertsch
Copy link
Contributor

Before
Screenshot 2022-02-24 at 14 58 44

After
Screenshot 2022-02-24 at 15 03 00

(second button)
Screenshot 2022-02-24 at 15 06 53

@vanpertsch vanpertsch added the 3. to review Waiting for reviews label Feb 24, 2022
@vanpertsch vanpertsch added this to the Nextcloud 24 milestone Feb 24, 2022
@vanpertsch vanpertsch self-assigned this Feb 24, 2022
jancborchardt
jancborchardt approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice design-wise :) code not checked

@vanpertsch vanpertsch force-pushed the fix/31237/new-button-authTokenSetupDialogue branch from 957b728 to 445c4a9 Compare February 24, 2022 17:12
@vanpertsch vanpertsch force-pushed the fix/31237/new-button-authTokenSetupDialogue branch from 445c4a9 to 6bf51dc Compare March 1, 2022 07:27
@vanpertsch
Copy link
Contributor Author

/compile amend /

@vanpertsch @nextcloud-command
use new button component
800f5f1 
Signed-off-by: Vanessa Pertsch <vanessa.pertsch@posteo.com>
Signed-off-by: Vanessa Pertsch <vanessa.pertsch@posteo.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/31237/new-button-authTokenSetupDialogue branch from 6bf51dc to 800f5f1 Compare March 1, 2022 07:37
@vanpertsch vanpertsch merged commit abf935c into master Mar 1, 2022
@vanpertsch vanpertsch deleted the fix/31237/new-button-authTokenSetupDialogue branch March 1, 2022 08:16
This was referenced Mar 16, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@vanpertsch vanpertsch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
3 participants
@vanpertsch @jancborchardt @marcoambrosini