Don't provide favorite activity settings

[nickvergessen]

Since mails and notifications are only available for actions of other users
it does not make sense to allow changing this.
It also prevents the common misunderstanding with
"file was changed inside a favorited folder"

[artonge]

If users have enabled it, will they now be able to disable it?

[nickvergessen]

If users have enabled it, will they now be able to disable it?

Since the setting does not have any effect at all, it does not matter?

[artonge]

For me, this setting was sending a notification when another user had access to one of my favourite folders and added or deleted a file.

If this is not the case, then why not remove it altogether?

[nickvergessen]

This is not what the setting is about, this setting would kick in when someone else favorites or unfavorites a file for you. But they can not do that, as everyone can only do this for themselves.

Mails/push can not filter for favorites of others at the moment.

[artonge]

Thanks for the explanation. So we keep it in the hope that we implement that one day?

[nickvergessen]

So we keep it in the hope that we implement that one day?

No, that is handled in FileFavoriteChanged

We never the less need to keep FavoriteAction so the messages are rendered in the stream

[nickvergessen]

/backport to stable23

[nickvergessen]

/backport to stable22

[nickvergessen]

/backport to stable21

[eaCodet]

For me, this setting was sending a notification when another user had access to one of my favourite folders and added or deleted a file.

This is exactly what I am looking for. The settings and the text suggest this behaviour. So if it worked at some point exactly this way why not make it work again?

[eaCodet]

Still looking: notification for as favourites tagged directories. The settings and the text suggest this to work. Is there a way to make this work by now?