-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix email verification #30491
Merged
Merged
Fix email verification #30491
+43
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
requested review from
PVince81,
skjnldsv and
come-nc
and removed request for
a team
January 5, 2022 04:12
/backport to stable23 |
/backport to stable22 |
can we have a unit test for this? |
Pytal
force-pushed
the
fix/30374/email-verification
branch
6 times, most recently
from
January 5, 2022 23:57
a9c26ae
to
da95465
Compare
come-nc
approved these changes
Jan 6, 2022
skjnldsv
approved these changes
Jan 6, 2022
Pytal
force-pushed
the
fix/30374/email-verification
branch
2 times, most recently
from
January 6, 2022 20:03
4b425b3
to
0fdba2c
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/30374/email-verification
branch
from
January 6, 2022 23:47
0fdba2c
to
19a3656
Compare
Test updated and passing, would appreciate a re-review or another review now with the updated test :) |
blizzz
approved these changes
Jan 7, 2022
This was referenced Jan 7, 2022
Pytal
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
bug
feature: emails
feature: users and groups
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30374