Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix groupware visual issue and improve spacing #30338

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

quentinguidee
Copy link
Member

Motivation

  • There's a bug in the groupware > availability section where the text is collapsed in the table.
  • The spacing of the page doesn't allows to instantly see the difference between the description, the settings and the save button.

Screenshots

Before screenshot-before
After collapsed text fix screenshot-after-1
After spacing rework screenshot-after-2 screenshot-after-3

@quentinguidee
Copy link
Member Author

(not reflected in the screenshots, but the last commit lowers the "+" icon of 1px)

Signed-off-by: Quentin Guidée <quentin.guidee@gmail.com>
Signed-off-by: Quentin Guidée <quentin.guidee@gmail.com>
@quentinguidee
Copy link
Member Author

Screenshots after the last commit to remove additional class :

Capture d’écran 2021-12-20 à 12 08 24

Capture d’écran 2021-12-20 à 12 08 32

@jancborchardt jancborchardt added 3. to review Waiting for reviews design Design, UI, UX, etc. enhancement labels Dec 20, 2021
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thank you @quentinguidee! :)

Signed-off-by: Quentin Guidée <quentin.guidee@gmail.com>
@GretaD GretaD merged commit a5953c3 into nextcloud:master Dec 22, 2021
JuliaKirschenheuter added a commit to nextcloud/calendar-availability-vue that referenced this pull request Feb 21, 2022
port PR 30338
extend .gitignore
JuliaKirschenheuter added a commit to nextcloud/calendar-availability-vue that referenced this pull request Feb 22, 2022
port PR 30338
extend .gitignore

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
JuliaKirschenheuter added a commit to nextcloud/calendar-availability-vue that referenced this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants