Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable22] Fix share owner not being displayed in sharing tab #30316

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Dec 17, 2021

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #30266

@CarlSchwan
Copy link
Member

/compile amend

This only concerns subfolder and files inside a shared folder and is
used as fallback when the OCS api returns a empty result, because it
only works on the shared folder and not the content inside of it.
This unify the tab with the folder list.

This offers a less descriptive share information but making the
OCS api returns all the details even for the subfolder would very
probably be bad for performance (since we would need to fetch the shares
for all the parent folders until we found one or are in the root folder).

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge
Copy link
Contributor

artonge commented Dec 30, 2021

Backport seem complete and CI failure is unrelated, merging.

@artonge artonge merged commit 2451f65 into stable22 Dec 30, 2021
@artonge artonge deleted the backport/30266/stable22 branch December 30, 2021 09:59
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2022
9 tasks
This was referenced Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants