Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable21] Avoid calling image* methods on boolean #30117

Merged
merged 3 commits into from
Dec 14, 2021
Merged

[stable21] Avoid calling image* methods on boolean #30117

merged 3 commits into from
Dec 14, 2021

Commits on Dec 14, 2021

  1. Avoid calling image* methods on boolean 

    This avoids fatal errors on PHP>=8, and warnings on older versions.
Log should also be clearer.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    3f10cf8 View commit details
    Browse the repository at this point in the history

  2. Fix typing problems in OC_Image 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    0799713 View commit details
    Browse the repository at this point in the history

  3. Avoid assignment in if clause 

    Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
    @come-nc
    come-nc committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    e34ec33 View commit details
    Browse the repository at this point in the history