Avoid calling image* methods on boolean #30040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
come-nc
requested review from
solracsf,
a team,
nickvergessen,
ArtificialOwl and
juliusknorr
and removed request for
a team
come-nc
force-pushed
the
fix/images-php-8.0-2
branch
from
e7dde95
to
e5d69d4
Compare
nickvergessen
approved these changes
Dec 2, 2021
solracsf
approved these changes
Dec 3, 2021
come-nc
force-pushed
the
fix/images-php-8.0-2
branch
2 times, most recently
from
d74f4aa
to
1d76114
Compare
This avoids fatal errors on PHP>=8, and warnings on older versions. Log should also be clearer. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/images-php-8.0-2
branch
from
1d76114
to
8504f0a
Compare
This was referenced Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids fatal errors on PHP>=8, and warnings on older versions.
Log should also be clearer.
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com
Fixes #29990