-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow scripts prioritization based on other apps #30015
Conversation
984a494
to
7cbf78f
Compare
b710397
to
4d970b7
Compare
This is still a very fragile system, isn't it? It only works because we include the scripts in an sync fashion, therefore causing a slow page load. Once we do the recommended async loading the order script tags won't matter anymore and the same problems show. What part of viewer is it that other apps have to await before they can run? Does viewer do anything async in its initialization? |
0c9a8c8
to
b9c5ca7
Compare
Yes and no. On the frontend, viewer can then wait for the |
Well, this is an entirely different issue to address. We'd have to rebuild our entire way to think (how we design APIS, how we register namespaces, etc etc), maybe it's a good first step? EDIT: @ChristophWurst So, we apparently already defer all scripts. And it works with this change. So I guess it's all good! :) |
3447c6c
to
db56bd2
Compare
Tests fixed |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
db56bd2
to
0e49593
Compare
I was more thinking of moving the script tags from head to body but 👍 |
800c592
to
0e49593
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
0e49593
to
3d94b9c
Compare
Was commiting |
It should not be in git. Run |
Yes 😢 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
3d94b9c
to
791d570
Compare
Sad CI noise |
Required by nextcloud/server#30015 Signed-off-by: Jonas Meurer <jonas@freesources.org>
Required by nextcloud/server#30015 Signed-off-by: Jonas Meurer <jonas@freesources.org>
Required by nextcloud/server#30015 Signed-off-by: Jonas Meurer <jonas@freesources.org>
Example given:
files_pdfviewer
depends onviewer
(Comply to new addScript API files_pdfviewer#522)viewer
depends onfiles
(Comply to new addScript API viewer#1081)files
depends oncore
Before we had to rely on luck, then use a watcher to catch any initialization that came after Viewer got updated.
Now, I can only check on viewer initialization and that's it.
Rules: