Force Calendar Object Change Path to support public write #29594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
requested review from
ChristophWurst,
tcitworld,
kesselb and
skjnldsv
skjnldsv
reviewed
Nov 8, 2021
skjnldsv
approved these changes
Nov 8, 2021
miaulalala
force-pushed
the
fix/force-calendar-object-change-path
branch
from
2f2fb33
to
4a371b5
Compare
tcitworld
approved these changes
Nov 8, 2021
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/force-calendar-object-change-path
branch
from
4a371b5
to
da22791
Compare
ChristophWurst
approved these changes
Nov 8, 2021
ChristophWurst
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces the path of the object calendar change to a value set by the public write api.
Forcing the change URI is neccessary because we're stepping into the logic a layer below a HTTP Request that would typically send this parameter and provide it to the scheduling plugin.
Without this change, a scheduling message will not be generated for the attendee(s).