Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to composer 2.1.11 #29555

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Update to composer 2.1.11 #29555

merged 1 commit into from
Nov 4, 2021

Conversation

CarlSchwan
Copy link
Member

Signed-off-by: Carl Schwan carl@carlschwan.eu

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Nov 4, 2021
@CarlSchwan CarlSchwan self-assigned this Nov 4, 2021
@nickvergessen
Copy link
Member

This caused a local diff all the time, CI still passed because we only check the autoload file there (not Installed*.php)
https://github.com/nextcloud/server/blob/master/build/autoloaderchecker.sh#L39

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 4, 2021
@nickvergessen nickvergessen added this to the Nextcloud 23 milestone Nov 4, 2021
@CarlSchwan CarlSchwan merged commit addab1e into master Nov 4, 2021
@CarlSchwan CarlSchwan deleted the update-composer-2-1-11 branch November 4, 2021 15:31
@CarlSchwan
Copy link
Member Author

This caused a local diff all the time, CI still passed because we only check the autoload file there (not Installed*.php) https://github.com/nextcloud/server/blob/master/build/autoloaderchecker.sh#L39

For the reference there is unfortunately no solution since the hash is the current commit. So then committing a change, the hash will also change. At least it fixes the InstalledVersion.php files

@skjnldsv skjnldsv mentioned this pull request Nov 8, 2021
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants