Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unsupported scopes for new account properties #29545

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Nov 4, 2021

Disable unsupported scopes for new account properties used on profile plus some minor wording updates for clarity and to make the scope menu shorter

@Pytal Pytal added bug 3. to review Waiting for reviews feature: settings feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Nov 4, 2021
@Pytal Pytal added this to the Nextcloud 23 milestone Nov 4, 2021
@Pytal Pytal requested a review from a team November 4, 2021 01:47
@Pytal Pytal self-assigned this Nov 4, 2021
@Pytal Pytal requested review from PVince81, artonge and szaimen and removed request for a team November 4, 2021 01:47
@Pytal

This comment has been minimized.

@nextcloud-command nextcloud-command force-pushed the fix/supported-scopes-profile-properties branch from e21b04b to 8289e2b Compare November 4, 2021 01:55
@Pytal Pytal changed the title Don't display unsupported scopes for new account properties Disable unsupported scopes for new account properties Nov 4, 2021
@skjnldsv
Copy link
Member

skjnldsv commented Nov 4, 2021

Please rebase

@Pytal Pytal force-pushed the fix/supported-scopes-profile-properties branch from 8289e2b to bfb7cd9 Compare November 4, 2021 23:04
@Pytal
Copy link
Member Author

Pytal commented Nov 4, 2021

/compile amend /

- Shorten disabled scope messages
- Update wording

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/supported-scopes-profile-properties branch from bfb7cd9 to 5b3a114 Compare November 4, 2021 23:13
@Pytal Pytal merged commit ec4474c into master Nov 5, 2021
@Pytal Pytal deleted the fix/supported-scopes-profile-properties branch November 5, 2021 02:55
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 5, 2021
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2021
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) feature: settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants