Fix missing calendar path for public write on Calendars #29536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Nov 3, 2021
tcitworld
reviewed
Nov 4, 2021
miaulalala
force-pushed
the
fix/add-full-calendar-path-for-public-write
branch
from
779d99d
to
6fff63d
Compare
ChristophWurst
approved these changes
Nov 4, 2021
ChristophWurst
force-pushed
the
fix/add-full-calendar-path-for-public-write
branch
from
6fff63d
to
169b1a4
Compare
tcitworld
approved these changes
Nov 4, 2021
ChristophWurst
added
4. to release
ChristophWurst
force-pushed
the
fix/add-full-calendar-path-for-public-write
branch
from
169b1a4
to
92678d8
Compare
miaulalala
force-pushed
the
fix/add-full-calendar-path-for-public-write
branch
from
92678d8
to
0f8a18d
Compare
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/add-full-calendar-path-for-public-write
branch
from
1d52107
to
bc68108
Compare
ChristophWurst
deleted the
fix/add-full-calendar-path-for-public-write
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Public createFromString method, a public write isn't actually possible because the full calendar path is not available.
This PR fixes this issue by generating the full calendar path for a specific calendar instance.
Follow-up to #29188