Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update update-psalm-baseline workflow #29529

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Update update-psalm-baseline workflow #29529

merged 1 commit into from
Nov 4, 2021

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 3, 2021 •
edited
Loading

  • use proper versions
  • request server backend team as reviewers
  • allow to run manually

@skjnldsv
Update update-psalm-baseline.yml
6ee4e6a 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Nov 3, 2021
@skjnldsv skjnldsv self-assigned this Nov 3, 2021
@skjnldsv skjnldsv requested review from a team, nickvergessen, PVince81 and icewind1991 and removed request for a team November 3, 2021 09:24
@juliusknorr juliusknorr merged commit 1dc487b into master Nov 4, 2021
@juliusknorr juliusknorr deleted the fix/update-psalm-baseline branch November 4, 2021 08:49
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 4, 2021 •
edited
Loading

Hum,
https://github.com/nextcloud/server/runs/4102839306?check_suite_focus=true

Maybe we should still continue on failure 🤔
https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 4, 2021

#29546

@juliusknorr
Copy link
Member

Makes sense. The error itself seems to come from https://github.com/nextcloud/server/pull/29502/files#diff-64a02ee1149d33d0747360694c2abf4ef1bdbfc379b4bb40f76c22b5b1fc06d9R1085

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 4, 2021

/backport to stable22

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 4, 2021

/backport to stable21

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 4, 2021

/backport to stable20

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 4, 2021

Makes sense. The error itself seems to come from #29502 (files)

Added in #29547

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@skjnldsv skjnldsv mentioned this pull request Nov 8, 2021
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@Pytal Pytal Pytal approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@PVince81 PVince81 Awaiting requested review from PVince81

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @juliusknorr @Pytal