Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure trusted_proxies is an array #29522

Merged

Conversation

nickvergessen
Copy link
Member

Fix #26256

@nickvergessen nickvergessen added this to the Nextcloud 23 milestone Nov 2, 2021
@nickvergessen nickvergessen self-assigned this Nov 2, 2021
@nickvergessen nickvergessen requested review from skjnldsv and come-nc and removed request for a team November 2, 2021 14:38
@nickvergessen nickvergessen force-pushed the bugfix/26256/make-sure-trusted_proxies-is-an-array branch from e730bf0 to b334c5c Compare November 2, 2021 15:56
@nickvergessen
Copy link
Member Author

/backport to stable22

@nickvergessen
Copy link
Member Author

/backport to stable21

@nickvergessen nickvergessen force-pushed the bugfix/26256/make-sure-trusted_proxies-is-an-array branch from b334c5c to 1c635a4 Compare November 3, 2021 10:09
@nickvergessen
Copy link
Member Author

Rebasing fixes psalm? lets see

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 3, 2021
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2021
19 tasks
@blizzz blizzz mentioned this pull request Nov 3, 2021
18 tasks
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2021
23 tasks
Signed-off-by: Joas Schilling <coding@schilljs.com>
… mock using a method list that contains duplicates:

Signed-off-by: Joas Schilling <coding@schilljs.com>
…ller\CheckSetupController::__construct()

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/26256/make-sure-trusted_proxies-is-an-array branch from 1c635a4 to e8f7a08 Compare November 9, 2021 14:13
@nickvergessen
Copy link
Member Author

Rebasing fixes psalm? lets see

@nickvergessen nickvergessen merged commit 9673579 into master Nov 10, 2021
@nickvergessen nickvergessen deleted the bugfix/26256/make-sure-trusted_proxies-is-an-array branch November 10, 2021 13:12
@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy header warning disappear when trusted_proxies is set to an invalid value
3 participants