Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable21] Fix bug introduced on drag and drop external files #29282

Merged
merged 1 commit into from
Oct 19, 2021

Commits on Oct 17, 2021

  1. Fix bug introduced on drag and drop external files

    Drag and drop of external (OS filesystem) to subdirectories in the browser would fail on specific cases, mainly when the subdirectory was no longer off the root folder.
    This seemed to have been an issue introduced with the subdirectory free space calculation [here](f9536b0) and it seems to fail for any subdirectory that doesn't belong to the root folder.
    
    Bug reports:
    - https://help.nextcloud.com/t/drag-drop-into-subfolders/120731
    - #24720
    
    I couldn't find any reference on scenarios or quota management that would suggest when a subdirectory's free space would be different to the parent's free space, other than when on the root folder, where subdirectories can be external mounts.
    
    As such, if my understanding is correct (please review), this calculation can - and should - be made by getting the free space from the first subdirectory in the total path, which caters for all subdirectory scenarios.
    
    Please advise, happy to help improve this.
    
    Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
    Signed-off-by: pjft <pjft@users.noreply.github.com>
    2 people authored and backportbot[bot] committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    3ae5213 View commit details
    Browse the repository at this point in the history