Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable22] Added support for transferring incoming file shares. #28844

Merged
merged 2 commits into from
Sep 15, 2021
Merged

[stable22] Added support for transferring incoming file shares. #28844

merged 2 commits into from
Sep 15, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #28118

@backportbot-nextcloud backportbot-nextcloud bot added enhancement feature: occ pending documentation This pull request needs an associated documentation update labels Sep 15, 2021
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 22.1.2 milestone Sep 15, 2021
@PVince81 PVince81 self-assigned this Sep 15, 2021
@PVince81
Copy link
Member

strange that the DCO bot accepted the mixed Author+Signed off by in the original PR but not this one

PVince81 and others added 2 commits September 15, 2021 12:18
@PVince81 @ipasanec
Added support for transfering incoming file shares.
249582a 
- new option --transfer-incoming-shares=1 | 0
- new config.php option 'transfer-incoming-shares' => true | false

The command line option overrules the config.php option.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Co-authored-by: Immanuel Pasanec <immanuel.pasanec@compaso.de>
@PVince81
Test for transfer ownership with incoming shares
42239fc 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member

to fix the DCO issue I made myself main author of the first commit and added Immanuel as Co-Author.

PVince81
PVince81 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added the 3. to review Waiting for reviews label Sep 15, 2021
@PVince81 PVince81 merged commit 4d5ee24 into stable22 Sep 15, 2021
@PVince81 PVince81 deleted the backport/28118/stable22 branch September 15, 2021 14:56
@blizzz blizzz mentioned this pull request Sep 23, 2021
Merged
4 tasks
@MichaIng MichaIng modified the milestones: Nextcloud 22.1.2, Nextcloud 22.2.0 Sep 24, 2021
@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@blizzz blizzz blizzz approved these changes

@artonge artonge Awaiting requested review from artonge

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@ipasanec ipasanec Awaiting requested review from ipasanec

@LEDfan LEDfan Awaiting requested review from LEDfan

@miaulalala miaulalala Awaiting requested review from miaulalala

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@PVince81 PVince81

Labels
3. to review Waiting for reviews enhancement feature: occ
Projects
None yet
Milestone
Nextcloud 22.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@PVince81 @blizzz @nickvergessen @MichaIng