Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable22] Allow users to choose a different email for notifications #28780

Merged
merged 8 commits into from
Sep 10, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Sep 10, 2021

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #28422

@backportbot-nextcloud backportbot-nextcloud bot added enhancement feature: users and groups pending documentation This pull request needs an associated documentation update labels Sep 10, 2021
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 22.1.2 milestone Sep 10, 2021
- to make it reusable
- needed for local email verification

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- mails added by (sub)admins are automatically verified
- provisioning_api controller as verification endpoint
- IAccountProperty gets a locallyVerified property
- IPropertyCollection gets a method to fetch an IAccountProperty by value
  - an remove equivalent was already present
- AccountManager always initiates mail verification on update if necessary
- add core success template for arbitrary title and message

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added the 3. to review Waiting for reviews label Sep 10, 2021
- this is to avoid automatic confirmation by certain softwares that open
  links

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- specific getters and setters on IUser and implementation
- new notify_email field in provisioning API

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- there will be times when it is necessary to reset this value for sure

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@skjnldsv skjnldsv merged commit 317e04d into stable22 Sep 10, 2021
@skjnldsv skjnldsv deleted the backport/28422/stable22 branch September 10, 2021 13:29
@blizzz blizzz mentioned this pull request Sep 23, 2021
4 tasks
@MichaIng MichaIng modified the milestones: Nextcloud 22.1.2, Nextcloud 22.2.0 Sep 24, 2021
@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants