Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable22] Only recommand for php-sodium on >= PHP 7.4 #28658

Merged
merged 1 commit into from
Aug 31, 2021
Merged

[stable22] Only recommand for php-sodium on >= PHP 7.4 #28658

merged 1 commit into from
Aug 31, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #28332

@CarlSchwan @backportbot
Only recommand for php-sodium on >= PHP 7.4
320a947 
This is because php-sodium will solve the missing PASSWORD_ARGON2I
constant problem only on >= php 7.4, previously argon2 wasn't part of
the standard extension and was disabled on Centos/RHEL.

So installing php-sodium on php 7.2 for example wouldn't hide the
message. Tested on Fedora with php 7.4, Centos 7 with php 7.2,
Centos 8 with php 7.2 and openSUSE with php 7.4.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 22.1.2 milestone Aug 31, 2021
@MichaIng MichaIng merged commit a022cf8 into stable22 Aug 31, 2021
@MichaIng MichaIng deleted the backport/28332/stable22 branch August 31, 2021 09:57
@blizzz blizzz mentioned this pull request Sep 23, 2021
Merged
4 tasks
@MichaIng MichaIng modified the milestones: Nextcloud 22.1.2, Nextcloud 22.2.0 Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaIng MichaIng MichaIng approved these changes

@szaimen szaimen szaimen approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud 22.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaIng @szaimen @CarlSchwan