Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable21] 3rdparty: Bump icewind/streams from 0.7.2 to 0.7.5 #28505

Merged
merged 2 commits into from
Oct 8, 2021
Merged

[stable21] 3rdparty: Bump icewind/streams from 0.7.2 to 0.7.5 #28505

merged 2 commits into from
Oct 8, 2021

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 19, 2021 •
edited by PVince81
Loading

@juliusknorr juliusknorr added 3. to review Waiting for reviews dependencies labels Aug 19, 2021
@solracsf solracsf linked an issue Aug 20, 2021 that may be closed by this pull request
[S3] fclose(): supplied resource is not a valid stream resource #28496
Closed
@solracsf
Copy link
Member

Should close #28496

@PVince81
Copy link
Member

PVince81 commented Oct 8, 2021

taking over

@PVince81 PVince81 self-assigned this Oct 8, 2021
@PVince81 PVince81 mentioned this pull request Oct 8, 2021
Closed
@PVince81
Update 3rdparty for icewind/streams 0.7.5
ea674e1 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 mentioned this pull request Oct 8, 2021
Merged
@PVince81 PVince81 added this to the Nextcloud 21.0.6 milestone Oct 8, 2021
@kesselb
Copy link
Contributor

kesselb commented Oct 8, 2021 •
edited
Loading

server/lib/private/Files/Stream/Encryption.php

Line 527 in 7588342

* @return integer

please change to int|false to make psalm happy like here: 581cbdc#diff-2fcbccc9cd6ad9e6a81a351b2c9e9c11bd65152895c633b6f95c550585d232b7

@PVince81
Fix psalm issue in Encryption stream
9722bb5 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member

PVince81 commented Oct 8, 2021

server/lib/private/Files/Stream/Encryption.php

Line 527 in 7588342

* @return integer

please change to int|false to make psalm happy like here: 581cbdc#diff-2fcbccc9cd6ad9e6a81a351b2c9e9c11bd65152895c633b6f95c550585d232b7

done, thanks for the hint

@kesselb kesselb merged commit 4fffc51 into stable21 Oct 8, 2021
@kesselb kesselb deleted the 3rdparty/730 branch October 8, 2021 12:26
@blizzz blizzz mentioned this pull request Nov 3, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@PVince81 PVince81

Labels
3. to review Waiting for reviews dependencies
Projects
None yet
Milestone
Nextcloud 21.0.6
Development

Successfully merging this pull request may close these issues.

[S3] fclose(): supplied resource is not a valid stream resource
5 participants
@juliusknorr @solracsf @PVince81 @kesselb @skjnldsv