-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not retain VerifyUserData job when lookup server is not available #28466
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Good with me. Is there an option to trigger them in case it is once switched on? |
The only way would be to update the account data manually, but that would be the same as before as the job also gets removed after 24 retries. (~1 day) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…n users. This avoids performance degradation of user creation batches from migration. It avoid the creation of Verify jobs completels (which are not needed for oidc users anyway) See nextcloud#28466 Signed-off-by: Bernd.Rederlechner@t-systems.com <bernd.rederlechner@t-systems.com>
…n users. This avoids performance degradation of user creation batches from migration. It avoid the creation of Verify jobs completels (which are not needed for oidc users anyway) See nextcloud#28466 Signed-off-by: Bernd.Rederlechner@t-systems.com <bernd.rederlechner@t-systems.com>
…n users. This avoids performance degradation of user creation batches from migration. It avoid the creation of Verify jobs completels (which are not needed for oidc users anyway) See nextcloud#28466 Signed-off-by: Bernd.Rederlechner@t-systems.com <bernd.rederlechner@t-systems.com>
…n users. This avoids performance degradation of user creation batches from migration. It avoid the creation of Verify jobs completels (which are not needed for oidc users anyway) See nextcloud#28466 Signed-off-by: Bernd.Rederlechner@t-systems.com <bernd.rederlechner@t-systems.com>
/backport to stable22 |
If the lookup server is disabled there is no need to retain a VerifyUserData job since any of the 24 attempts to verify will never succeed if the server is configured like that.
This will save some unnecessary load on the cron job execution as well as making the oc_jobs table stay in lower numbers during mass user creation.