Fix setting up 2FA providers when 2FA is enforced and bc are generated #28262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user has backup codes generated and got their 2FA enforced then they should be able to set up TOTP and similar providers during the login. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
rullzer,
LukasReschke,
blizzz,
kesselb and
artonge
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
ChristophWurst
added
3. to review
kesselb
approved these changes
Aug 25, 2021
kesselb
deleted the
fix/set-up-2fa-providers-enforced-with-backup-codes
branch
This was referenced Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user has backup codes generated and got their 2FA enforced then
they should be able to set up TOTP and similar providers during the
login.
Currently the user is redirected to the backup codes page because that's the only available provider. Going back to the 2FA setup page is not possible.
Will give this some more testing, just to be sure :)doneSteps to test
Expected behavior (here)
You are told that 2FA is enforced but not set up. You can pick TOTP for the setup, configure it and then you're logged in and set up.
Actual behavior (on master)
You are redirected to the backup codes page, there is nothing you can do except fill in a backup code.