Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix too many file download notifications when watching a video #28227

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Fix too many file download notifications when watching a video #28227

merged 1 commit into from
Mar 7, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 29, 2021 •
edited
Loading

@szaimen szaimen added the 2. developing Work in progress label Jul 29, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Jul 29, 2021
@szaimen szaimen force-pushed the enh/noid/report-remoteAddress branch 18 times, most recently from 34bbc6e to c202fb0 Compare July 29, 2021 11:22
@szaimen szaimen changed the title Allow to report the remoteAddress Report the remoteAddress for download activities and merge equal ones Jul 29, 2021
@szaimen
Copy link
Contributor Author

szaimen commented Jul 29, 2021

I think the failing test is unrelated

@szaimen szaimen marked this pull request as ready for review July 29, 2021 18:40
@szaimen szaimen requested review from nickvergessen and a team July 29, 2021 18:40
@szaimen szaimen force-pushed the enh/noid/report-remoteAddress branch from 3563d02 to 648efdb Compare March 7, 2022 13:32
@szaimen szaimen force-pushed the enh/noid/report-remoteAddress branch from 648efdb to d78c2ec Compare March 7, 2022 13:40
@szaimen szaimen added 3. to review Waiting for reviews bug and removed 2. developing Work in progress pending documentation This pull request needs an associated documentation update enhancement labels Mar 7, 2022
@szaimen szaimen requested review from skjnldsv, Pytal and juliusknorr and removed request for nickvergessen March 7, 2022 13:55
@szaimen
Copy link
Contributor Author

szaimen commented Mar 7, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Mar 7, 2022

/backport to stable22

@szaimen

This comment was marked as resolved.

Sign in to view
@szaimen
Copy link
Contributor Author

szaimen commented Mar 7, 2022

/rebase for checking if all checks pass

@szaimen
Fix too many file download notifications when watching a video
ccd0887 
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen merged commit 019117c into master Mar 7, 2022
@szaimen szaimen deleted the enh/noid/report-remoteAddress branch March 7, 2022 20:48
This was referenced Mar 7, 2022
Merged
Merged
@szaimen szaimen mentioned this pull request Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@Pytal Pytal Pytal approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@PVince81 PVince81 Awaiting requested review from PVince81

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: activity and notification
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

Hundreds of notifications when a shared video is played in the browser Shared videos count multiple times
8 participants
@szaimen @kesselb @wagnbeu0 @Karem-sobhy @nickvergessen @juliusknorr @skjnldsv @Pytal