Scheduling plugin not updating responding attendee status

[miaulalala]

Fixes nextcloud/calendar#2861

[miaulalala]

Shall we backport this?

[ChristophWurst]

/backport to stable22

[ChristophWurst]

/backport to stable21

[ChristophWurst]

/backport to stable20

[miaulalala]

Drone failure is unrelated

[kesselb]

I'm not able to reproduce the initial issue on master anymore. On master and this branch the attendance status is updated properly and shows the right state 😕

[kesselb]

I'm not able to reproduce the initial issue on master anymore. On master and this branch the attendance status is updated properly and shows the right state confused

My bad 🙈 I looked at the wrong point. For master and this pull request the attendance status for the organizer is updated properly.

The purpose of this pull request is to fix an issue with updating the attendance status for the attendee itself. To reproduce create a event and invite Alice and Bob. Wait for Bob's invitation email and accept the invite. The attendance status for the organizer and Alice is updated (Bob accepted the invite). In Bob's calendar event the attendance status is still pending.

A possible explanation for this case is the way we handle event invitations. If a user accept or decline an invitation a iTip message is generated.

server/apps/dav/lib/Controller/InvitationResponseController.php

Lines 200 to 201 in 215aef3

	$iTipMessage->sender = $row['attendee'];
	$iTipMessage->recipient = $row['organizer'];

The recipient is used to select the right event from the calendar. When Alice accept the invite an iTip message is generated with sender = alice@example.org and recipient = organizer@example.org. The event for recipient organizer@example.org is selected and the attendance status for alice@example.org updated. Then for every other attendee another iTip message is generated to also update their event.

https://github.com/nextcloud/3rdparty/blob/6876f1fce8d1c70790c165dd7ed0b4214364e397/sabre/dav/lib/CalDAV/Schedule/Plugin.php#L527-L538

Sabre assume that we already updated Alice event and there is no need to sent a iTip message to Alice.

$iTipMessage->sender = $row['attendee']; 
$iTipMessage->recipient = $row['attendee']; 

I'm not sure if that's a valid iTip message. But when sender = recipient the calendar event for the attendee is updated and a iTip message for the organizer and other attendees generated and properly updated.

Just adding my findings here to document it for later. I guess it's fine to merge this pull request and take out the ignore check.

[miaulalala]

This has been discussed an the actual RFC compliant way will be to update the recipient in the iTip Message. Thanks @kesselb for figuring this out!

[st3iny]

I tested it and the status was updated correctly for both the organizer and attendee. I didn't look at the code though.