Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LDAPProviderFactory not found #27732

Merged
merged 2 commits into from
Jun 30, 2021
Merged

Fix LDAPProviderFactory not found #27732

merged 2 commits into from
Jun 30, 2021

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jun 30, 2021

  • instantiates the factory class only when it exists
  • user_ldap unregister the factory class on disable

fixes #27576

@blizzz
ensure that factoryClass exisits before instantiation
12e4484 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 23 milestone Jun 30, 2021
@blizzz
Copy link
Member Author

blizzz commented Jun 30, 2021

/backport to stable22

@blizzz blizzz requested a review from skjnldsv June 30, 2021 13:18
@blizzz blizzz force-pushed the fix/27576/LDAPProviderFactory-not-found branch from 78e5d76 to f62c066 Compare June 30, 2021 13:24
@blizzz
unset ldap provider when disabling user_ldap
f62c066 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 30, 2021
@blizzz blizzz merged commit 6da9ccc into master Jun 30, 2021
@blizzz blizzz deleted the fix/27576/LDAPProviderFactory-not-found branch June 30, 2021 16:50
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 30, 2021
Merged
@ChristophWurst
Copy link
Member

https://help.nextcloud.com/t/error-on-upgrading-nextcloud/128281 seen also on stable21

@ChristophWurst
Copy link
Member

/backport to stable21

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@kesselb kesselb Awaiting requested review from kesselb

@artonge artonge Awaiting requested review from artonge

@dartcafe dartcafe Awaiting requested review from dartcafe

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: ldap regression
Projects
None yet
Milestone
Nextcloud 23
3 participants
@blizzz @ChristophWurst @skjnldsv