Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow certain custom DAV props to be readable by everyone #27426

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

ChristophWurst
Copy link
Member

This is a PoC to address the problems described in #27421.

Is this approach okay? Should we narrow down to specific paths only, like only expose calendar availability for inboxes? cc @blizzz @juliushaertl @tcitworld you are more experienced with DAV than me.

Fixes #27421

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 22 milestone Jun 8, 2021
@ChristophWurst ChristophWurst self-assigned this Jun 8, 2021
@tcitworld
Copy link
Member

Is this approach okay?

Sounds good to me. Not sure if we need to narrow it down, but we certainly need to check that you can access calendar availability unlogged for instance.

@ChristophWurst
Copy link
Member Author

we certainly need to check that you can access calendar availability unlogged for instance

What do you mean by unlogged?

@juliusknorr
Copy link
Member

juliusknorr commented Jun 9, 2021

Is this approach okay? Should we narrow down to specific paths only, like only expose calendar availability for inboxes?

Should be fine as it is i'd say as there is only a fix list allowed for published properties.

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 9, 2021
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@ChristophWurst ChristophWurst merged commit 2d1d939 into master Jun 10, 2021
@ChristophWurst ChristophWurst deleted the fix/dav-custom-props-no-scope branch June 10, 2021 06:00
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all custom DAV properties should be scoped to a user
5 participants