Prevent supplied resource is not a valid stream resource #27261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasSko
reviewed
Jun 5, 2021
Co-authored-by: Andreas Skorczyk <me@andreas-sk.de>
Merged
|
Fixed upstream already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logs are spammed with
fclose()not being able to close a non-resource:This happens for every file. This pull request aims to check if a source is a valid resource before
fclose()-ing, otherwise it silently returnstrueto avoid breaking compatibility.This occurs when the primary storage backend is S3/S3-compatible. Probably also happens in non-standard backends (Openstack, etc.) but wasn't tested.
This has been tested to work on my setup: