l10n: Remove space from translation #27197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Valdnet
requested review from
PVince81,
ChristophWurst,
rakekniven and
nickvergessen
ChristophWurst
approved these changes
May 28, 2021
gary-kim
approved these changes
May 28, 2021
gary-kim
added
4. to release
nickvergessen
requested changes
May 28, 2021
| @@ -52,7 +52,7 @@ | |||
| <p id="setDefaultInternalExpireDate" class="double-indent <?php if ($_['shareDefaultInternalExpireDateSet'] === 'no' || $_['shareAPIEnabled'] === 'no') { | |||
| p('hidden'); | |||
| }?>"> | |||
| <?php p($l->t('Expire after ')); ?> | |||
| <?php p($l->t('Expire after') . ' '); ?> | |||
There was a problem hiding this comment.
Pretty sure this works only in english/latin based languages ...
| @@ -52,7 +52,7 @@ | |||
| <p id="setDefaultInternalExpireDate" class="double-indent <?php if ($_['shareDefaultInternalExpireDateSet'] === 'no' || $_['shareAPIEnabled'] === 'no') { | |||
| p('hidden'); | |||
| }?>"> | |||
| <?php p($l->t('Expire after ')); ?> | |||
| <?php p($l->t('Expire after') . ' '); ?> | |||
| <input type="text" name='shareapi_internal_expire_after_n_days' id="shareapiInternalExpireAfterNDays" placeholder="<?php p('7')?>" | |||
| value='<?php p($_['shareInternalExpireAfterNDays']) ?>' /> | |||
| <?php p($l->t('days')); ?> | |||
There was a problem hiding this comment.
Plural here can not adjust to the input value...
I guess we have to restructure this thing a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Valdnet 47037905+Valdnet@users.noreply.github.com