Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub container registry #27125

Merged
merged 1 commit into from
May 28, 2021
Merged

Use GitHub container registry #27125

merged 1 commit into from
May 28, 2021

Conversation

LukasReschke
Copy link
Member

@LukasReschke LukasReschke commented May 26, 2021

To avoid Docker ratelimit issues.

TODO:

  • Update with GitHub Container Registry images

@LukasReschke
Copy link
Member Author

@MorrisJobke Do we have a GitHub bot account that we can use to reference the Secret for pulling?

Ref https://docs.drone.io/pipeline/docker/syntax/images/#pulling-private-images

(Currently GitHub registry requires authentication)

@MorrisJobke
Copy link
Member

@MorrisJobke Do we have a GitHub bot account that we can use to reference the Secret for pulling?

Yep - there is @nextcloud-bot and @nextcloud-pr-bot. Depends on how fine granular the permission for this token can be set. I would like to have a token purely for this registry pull. I assume that selecting no scope would do that, right?

Bildschirmfoto 2021-05-26 um 22 34 28

@MorrisJobke
Copy link
Member

Otherwise I would create a new account for that.

@LukasReschke
Copy link
Member Author

@splitt3r
Copy link
Contributor

splitt3r commented May 27, 2021

What about using the shiny new GitHub container registry instead of the old Packages? https://github.blog/2020-09-01-introducing-github-container-registry/ You would not have to migrate later on and it seems to have some cool feautres even if it is still in beta phase.

@LukasReschke
Copy link
Member Author

What about using the shiny new GitHub container registry instead of the old Packages? https://github.blog/2020-09-01-introducing-github-container-registry/ You would not have to migrate later on and it seems to have some cool feautres even if it is still in beta phase.

Giving that a try with nextcloud/docker-ci@a38d00c. Thanks :)

To avoid Docker ratelimit issues.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke added the 3. to review Waiting for reviews label May 27, 2021
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure unrelated

@MorrisJobke MorrisJobke merged commit 0769b17 into master May 28, 2021
@MorrisJobke MorrisJobke deleted the use-github-registry branch May 28, 2021 09:09
@MorrisJobke MorrisJobke added this to the Nextcloud 22 milestone May 28, 2021
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants