Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Dont allow reusing usernames #27105

Closed
wants to merge 11 commits into from
Closed

[WIP] Dont allow reusing usernames #27105

wants to merge 11 commits into from

Commits on Jun 2, 2021

  1. Dont allow reusing usernames 

    We have cases in which app developers forget to delete user data when a user is being deleted. This could be problematic as future users with the same username could then access this data.

This mitigates this risk a bit by not allowing reusing of usernames. That said, we still need to fix occurrences of these issues by deleting missed data.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
    @LukasReschke
    LukasReschke committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    39974ac View commit details
    Browse the repository at this point in the history

  2. Adjust tests to use different user IDs 

    Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
    @LukasReschke
    LukasReschke committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    4abf122 View commit details
    Browse the repository at this point in the history

  3. Flush duplicate usernames for integration tests 

    Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
    @LukasReschke
    LukasReschke committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    1d5cbd3 View commit details
    Browse the repository at this point in the history

  4. Use self::getUniqueID instead of uniqid 

    Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
    @LukasReschke
    LukasReschke committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    dfd9d5f View commit details
    Browse the repository at this point in the history

  5. Use single quotes instead double quotes 

    Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
    @LukasReschke
    LukasReschke committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    aef3f7c View commit details
    Browse the repository at this point in the history

  6. else if -> elseif 

    Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
    @LukasReschke
    LukasReschke committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    9ed3522 View commit details
    Browse the repository at this point in the history

  7. Use MockObject instead of PHPUnit_Framework_MockObject_MockObject 

    Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
    @LukasReschke
    LukasReschke committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    37543c0 View commit details
    Browse the repository at this point in the history

  8. Nest migration code 

    Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
    @LukasReschke
    LukasReschke committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    e09c99c View commit details
    Browse the repository at this point in the history

  9. Import namespaced MockObject 

    Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
    @LukasReschke
    LukasReschke committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    4b48154 View commit details
    Browse the repository at this point in the history

  10. Move null user test first 

    Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
    @LukasReschke
    LukasReschke committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    4cc3180 View commit details
    Browse the repository at this point in the history

  11. Disable testing app only conditionally 

    Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
    @LukasReschke
    LukasReschke committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    a4f6e19 View commit details
    Browse the repository at this point in the history