Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw when comments is disabled #27053

Merged

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 21, 2021

  1. Enable the announcementcenter app
  2. Disable the comments app
  3. Open the comments tab of an announcement

Fix nextcloud/announcementcenter#328

@nickvergessen
Copy link
Member Author

/backport to stable21

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 21, 2021
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/dont-throw-when-comments-is-disabled branch from bde6b69 to 5ae5729 Compare May 21, 2021 10:04
@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
98 tasks
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
@nickvergessen nickvergessen merged commit 6578a93 into master Jun 2, 2021
@nickvergessen nickvergessen deleted the bugfix/noid/dont-throw-when-comments-is-disabled branch June 2, 2021 13:40
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal Log entry's "no app in context"
3 participants