Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return value of getStorageInfo when 'quota_include_external_storage' is enabled #27043

Merged
merged 1 commit into from
May 25, 2021
Merged

fix return value of getStorageInfo when 'quota_include_external_storage' is enabled #27043

merged 1 commit into from
May 25, 2021

Conversation

icewind1991
Copy link
Member

To test:

  • occ config:system:set quota_include_external_storage --value true --type boolean
  • set the user quota to something other than unlimited
  • load the webui and check the dev tools for the getstoragestats.php request

currently the owner, ownerDisplayName, mountType and mountPoint are set to null
with this PR they should be set to the correct values.

@icewind1991
fix return value of getStorageInfo when 'quota_include_external_stora…
7e22487 
…ge' is enabled

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label May 20, 2021
@icewind1991 icewind1991 added this to the Nextcloud 22 milestone May 20, 2021
@icewind1991
Copy link
Member Author

/backport to stable21

@icewind1991
Copy link
Member Author

/backport to stable20

MorrisJobke
MorrisJobke approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 6ed728d into master May 25, 2021
@MorrisJobke MorrisJobke deleted the storage-info-include-external branch May 25, 2021 19:57
This was referenced May 25, 2021
Merged
Merged
@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
Merged
98 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: external storage feature: files
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @nickvergessen @MorrisJobke