Add option to exclude groups from creating link shares #26727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How is this then shown to clients? |
|
Clients should see the same from the capabilities response as if link shares were completely disabled |
|
However, linting, psalm and phpunit are not happy |
MorrisJobke
added
2. developing
icewind1991
force-pushed
the
group-exclude-link-share
branch
3 times, most recently
from
253f504
to
9afb874
Compare
juliusknorr
reviewed
May 12, 2021
apps/files/list.php
Outdated
| $publicUploadEnabled = $config->getAppValue('core', 'shareapi_allow_public_upload', 'yes'); | ||
| /** @var IManager $shareManager */ | ||
| $shareManager = \OC::$server->get(IManager::class); | ||
| $publicUploadEnabled = $shareManager->shareApiLinkAllowPublicUpload(); |
There was a problem hiding this comment.
I couldn't find any usage of the data attribute where this value is assigned to but from a compatibility perspective we should probably preserve the yes/no values here:
Suggested change
| $publicUploadEnabled = $shareManager->shareApiLinkAllowPublicUpload(); | |
| $publicUploadEnabled = $shareManager->shareApiLinkAllowPublicUpload() ? 'yes' : 'no'; |
juliusknorr
requested changes
May 12, 2021
icewind1991
force-pushed
the
group-exclude-link-share
branch
2 times, most recently
from
1e333bc
to
094c4d5
Compare
juliusknorr
approved these changes
May 12, 2021
|
Now just the CapabilitiesTest still needs adjustments 😉 |
icewind1991
force-pushed
the
group-exclude-link-share
branch
from
094c4d5
to
83ce240
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
group-exclude-link-share
branch
from
83ce240
to
8d7fae8
Compare
Merged
MorrisJobke
added
3. to review
|
CI is happy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would have hoped to solve this in a more generic "per group share settings" way but the way the code base interacts with the share settings is to messy to do that without a lot of rework (this PR includes some improvement in this area).