Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commands to manage tags via OCC #26600

Merged
merged 1 commit into from
May 25, 2021
Merged

Add commands to manage tags via OCC #26600

merged 1 commit into from
May 25, 2021

Conversation

noiob
Copy link
Contributor

@noiob noiob commented Apr 16, 2021

I'm adding tag:list, tag:add, tag:delete, and tag:edit commands to OCC

@noiob noiob force-pushed the feature/occ-tags branch 2 times, most recently from 1b8c894 to 260cd19 Compare April 16, 2021 17:01
@noiob noiob marked this pull request as ready for review April 16, 2021 17:12
@solracsf solracsf added the 3. to review Waiting for reviews label Apr 19, 2021
@rullzer rullzer added this to the Nextcloud 22 milestone Apr 20, 2021
rullzer
rullzer reviewed Apr 20, 2021
View reviewed changes
lib/public/SystemTag/ISystemTag.php Outdated
*
* @since 22.0.0
*/
public function getHumanReadableAccess(): string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure if we'd want this in the public API. As then it can never be translated.
Also maybe a constant is better than just a string? @ChristophWurst

Copy link
Contributor Author

@noiob noiob Apr 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to avoid code reuse in the commands. Not sure what would be a better solution? The result of this function could still be used as translation keywords. I wouldn't mind using a constant, but then I'd have to reuse more code

Copy link
Contributor Author

@noiob noiob May 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided to go ahead and implement a constant-based solution, which feels much cleaner. Please check it out and tell me what you think

nickvergessen
nickvergessen requested changes Apr 20, 2021
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments

core/Command/SystemTag/Add.php Show resolved Hide resolved
core/Command/SystemTag/Add.php Outdated Show resolved Hide resolved
core/Command/SystemTag/Delete.php Outdated Show resolved Hide resolved
core/Command/SystemTag/Edit.php Outdated Show resolved Hide resolved
core/Command/SystemTag/ListCommand.php Outdated Show resolved Hide resolved
core/Command/SystemTag/ListCommand.php Outdated Show resolved Hide resolved
core/Command/SystemTag/ListCommand.php Outdated Show resolved Hide resolved
core/register_command.php Show resolved Hide resolved
kesselb
kesselb reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Cool feature 🥳

core/Command/SystemTag/Add.php Outdated Show resolved Hide resolved
core/Command/SystemTag/Add.php Outdated Show resolved Hide resolved
core/Command/SystemTag/Add.php Outdated Show resolved Hide resolved
@noiob noiob requested a review from rullzer May 4, 2021 17:13
kesselb
kesselb reviewed May 10, 2021
View reviewed changes
core/Command/SystemTag/Add.php Outdated Show resolved Hide resolved
core/Command/SystemTag/Delete.php Show resolved Hide resolved
core/Command/SystemTag/Edit.php Show resolved Hide resolved
kesselb
kesselb reviewed May 11, 2021
View reviewed changes
lib/private/SystemTag/SystemTag.php Outdated Show resolved Hide resolved
lib/private/SystemTag/SystemTag.php Outdated Show resolved Hide resolved
lib/private/SystemTag/SystemTag.php Outdated Show resolved Hide resolved
core/Command/SystemTag/Add.php Outdated Show resolved Hide resolved
core/Command/SystemTag/Add.php Outdated Show resolved Hide resolved
core/Command/SystemTag/Add.php Show resolved Hide resolved
core/Command/SystemTag/Edit.php Show resolved Hide resolved
@MorrisJobke MorrisJobke mentioned this pull request May 20, 2021
Merged
kesselb
kesselb reviewed May 20, 2021
View reviewed changes
lib/public/SystemTag/ISystemTag.php Outdated Show resolved Hide resolved
lib/public/SystemTag/ISystemTag.php Outdated Show resolved Hide resolved
kesselb
kesselb approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

My other comments are only suggestions. Not required to get it in.

core/Command/SystemTag/Edit.php Outdated Show resolved Hide resolved
core/Command/SystemTag/Edit.php Outdated Show resolved Hide resolved
@kesselb
Copy link
Contributor

kesselb commented May 20, 2021 

The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result

@noiob
Add commands to manage tags via OCC
d606799 
list, add, delete, edit

Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
@kesselb kesselb mentioned this pull request May 25, 2021
Closed
@kesselb
Copy link
Contributor

kesselb commented May 25, 2021

I've rebased the branch on master: #27101
The acceptance tests does not fail: https://drone.nextcloud.com/nextcloud/server/5321

MorrisJobke
MorrisJobke approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke MorrisJobke merged commit 726d018 into nextcloud:master May 25, 2021
@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
Merged
98 tasks
@noiob noiob deleted the feature/occ-tags branch May 26, 2021 09:17
@szaimen szaimen mentioned this pull request May 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr left review comments

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@kesselb kesselb kesselb approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
7 participants
@noiob @kesselb @rullzer @nickvergessen @MorrisJobke @juliusknorr @solracsf