Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable21] Fix valid storages removed when cleaning remote storages #26192

Merged
merged 2 commits into from
Mar 18, 2021
Merged

[stable21] Fix valid storages removed when cleaning remote storages #26192

merged 2 commits into from
Mar 18, 2021

Commits on Mar 18, 2021

  1. Add integration tests for "sharing:cleanup-remote-storages" OCC command 

    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu @backportbot
    danxuliu authored and backportbot[bot] committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    388110a View commit details
    Browse the repository at this point in the history

  2. Fix valid storages removed when cleaning remote storages 

    The remote URL of a share is always stored in the database with a
trailing slash. However, when a cloud ID is generated trailing slashes
are removed.

The ID of a remote storage is generated from the cloud ID, but the
"cleanup-remote-storage" command directly used the remote URL stored in
the database. Due to this, even if the remote storage was valid, its ID
did not match the ID of the remote share generated by the command and
ended being removed.

Now the command generates the ID of remote shares using the cloud ID
instead, just like done by the remote storage, so there is no longer a
mismatch.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu @backportbot
    danxuliu authored and backportbot[bot] committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    7e87b12 View commit details
    Browse the repository at this point in the history