Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable19] Fix valid storages removed when cleaning remote storages #26191

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #25331

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The remote URL of a share is always stored in the database with a
trailing slash. However, when a cloud ID is generated trailing slashes
are removed.

The ID of a remote storage is generated from the cloud ID, but the
"cleanup-remote-storage" command directly used the remote URL stored in
the database. Due to this, even if the remote storage was valid, its ID
did not match the ID of the remote share generated by the command and
ended being removed.

Now the command generates the ID of remote shares using the cloud ID
instead, just like done by the remote storage, so there is no longer a
mismatch.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 18, 2021
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 18, 2021
@MorrisJobke MorrisJobke merged commit 2779940 into stable19 Mar 18, 2021
@MorrisJobke MorrisJobke deleted the backport/25331/stable19 branch March 18, 2021 12:09
@rullzer rullzer mentioned this pull request Mar 26, 2021
@rullzer rullzer mentioned this pull request Apr 8, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: federation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants