Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable21] remove explicit fclose from S3->writeStream #26167

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #26072

streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error

Signed-off-by: Robin Appelman <robin@icewind.nl>
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MorrisJobke MorrisJobke merged commit a2d17c3 into stable21 Mar 17, 2021
@MorrisJobke MorrisJobke deleted the backport/26072/stable21 branch March 17, 2021 12:47
@rullzer rullzer mentioned this pull request Mar 26, 2021
2 tasks
@rullzer rullzer mentioned this pull request Apr 8, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants