Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only clear known users when we had at least one phonebook entry #26080

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Only clear known users when we had at least one phonebook entry #26080

merged 1 commit into from
Mar 12, 2021

Conversation

nickvergessen
Copy link
Member

Steps

  1. Set up phonebook sync with 2 devices
  2. On device 1 fill your phonebook and enable sync
  3. On you testing device (device 2) have an empty phonebook and enable sync by accident
  4. All your entries are now removed again.

@nickvergessen
Only clear known users when we had at least one phonebook entry
5c3551c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 22 milestone Mar 12, 2021
@nickvergessen
Copy link
Member Author

/backport to stable21

PVince81
PVince81 approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 12, 2021
@blizzz blizzz merged commit 812bc83 into master Mar 12, 2021
@blizzz blizzz deleted the bugfix/noid/only-clear-known-users-when-we-had-at-least-one-phonebook-entry branch March 12, 2021 09:45
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz blizzz approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @PVince81 @ChristophWurst @blizzz