Increase debounce time to make sure controls are resized after the sidebar disappeared #2602
Conversation
|
@MariusBluem, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @MorrisJobke to be potential reviewers. |
| @@ -1502,7 +1502,7 @@ function initCore() { | |||
|
|
|||
| $(window).resize(_.debounce(adjustControlsWidth, 250)); | |||
|
|
|||
| $('body').delegate('#app-content', 'apprendered appresized', _.debounce(adjustControlsWidth, 100)); | |||
| $('body').delegate('#app-content', 'apprendered appresized', _.debounce(adjustControlsWidth, 500)); | |||
There was a problem hiding this comment.
Well just try what safari needs and use the smallest possible value?
There was a problem hiding this comment.
In 50-steps or is 100 enough?
There was a problem hiding this comment.
50 or 10? :P I don't care just make it fast
There was a problem hiding this comment.
For me this works with 150 -.- ... looks like a weird race condition. I tried to debug this: first I tried that the adjustControlsWidth is called too early - but this is somehow not the case.
MariusBluem
added
2. developing
|
@MariusBluem Can we move that to 12? I'd prefer to consider 11 closed for any non-critical merges. |
…debar disappeared Signed-off-by: Marius Blüm <marius@lineone.io>
MorrisJobke
force-pushed
the
resize-the-controls-after-the-sidebar-slided-in
branch
from
f6b1098
to
a460acb
Compare
MorrisJobke
added
3. to review
|
@MariusBluem @LukasReschke @georgehrke Can you give this a try in Safari? (having the gallery installed and open&close the sidebar in files app should result in the gallery switcher icon on the far right) Thanks |
|
@nickvergessen increasing the debounce time helped, but I have no idea why :( |
Ping ;) |
LukasReschke
deleted the
resize-the-controls-after-the-sidebar-slided-in
branch
Follow up of #2365 - Fixes #2346 😉 Still not perfect with Safari, but better than now 😅 It is now jumping back after some ms 😁
Signed-off-by: Marius Blüm marius@lineone.io