Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getID function to the simplefile implementation #26003

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Mar 8, 2021

Sometimes it is useful to get the actual fileid

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Sometimes it is useful to get the actual fileid

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wait, should be added to the public interface as well then I guess 😉

@rullzer
Copy link
Member Author

rullzer commented Mar 9, 2021

Ah wait, should be added to the public interface as well then I guess wink

Not for now. I'm not sure yet how to do it with the other implementations.
But also would like to backport this part. It is mainly for internal use this getId anyway.

@MorrisJobke MorrisJobke merged commit f512705 into master Mar 15, 2021
@MorrisJobke MorrisJobke deleted the enh/simplefile/getid branch March 15, 2021 13:41
@MorrisJobke
Copy link
Member

/backport to stable21

@MorrisJobke
Copy link
Member

/backport to stable20

@kesselb
Copy link
Contributor

kesselb commented Mar 17, 2021

/backport to stable20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants